Skip to content

Update Project Profile: 311 Data Remove Anna Kim #8057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Christopher-Chhim
Copy link
Member

@Christopher-Chhim Christopher-Chhim commented Apr 11, 2025

Fixes #7548

What changes did you make?

  • Removed Anna Kim's leadership variables.

Why did you make the changes (we will use this info to test)?

  • To keep list of active users on the 311 Data website up-to-date.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2025-04-10 193517

Visuals after changes are applied

Screenshot 2025-04-10 193447

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Christopher-Chhim-christopher-chhim-update-project-profile-7548 gh-pages
git pull https://github.com/Christopher-Chhim/website.git christopher-chhim-update-project-profile-7548

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 11, 2025
@Christopher-Chhim Christopher-Chhim changed the title Update-Project-Profile-7548 311 Data Remove Anna Kim Update-Project-Profile 7548 311 Data Remove Anna Kim Apr 11, 2025
@Christopher-Chhim Christopher-Chhim changed the title Update-Project-Profile 7548 311 Data Remove Anna Kim Update Project Profile: 311 Data Remove Anna Kim Apr 11, 2025
@Christopher-Chhim Christopher-Chhim requested review from pluto-bell, perlaroyerc and Copilot and removed request for pluto-bell April 12, 2025 19:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@andyvu923 andyvu923 self-requested a review April 16, 2025 03:09
@andyvu923
Copy link
Member

Review ETA: 4/16 EOD
Availability: Friday 4/17 6-9 PM

@daras-cu
Copy link
Member

Hey @Christopher-Chhim, the reviewers you had assigned are not active on the website project anymore-in general you should not assign reviewers unless they've agreed to look at your PR ahead of time. You can always post in the slack channel if you need reviews.

@TheManTheMythTheGameDev
Copy link
Member

Review ETA: 10 PM 4/15/25
Availability: 1-8 PM Sunday

Copy link
Member

@TheManTheMythTheGameDev TheManTheMythTheGameDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this pull request. There is one thing you need to change before this can be merged:

  • First of all, you don't need to include your username in the branch name. You don't have to change anything here, but keep this in mind for future pull requests.
  • Second, and more importantly, it seems there is an extra commit. You removed Emily Eldar from home-unite-us, when the issue we are solving is removing Anna Kim from 311 Data. It's great you want to solve both issues, but they should be in separate pull requests to keep things organized. It's possible you were trying to put them in separate PRs but accidentally used the same branch. No worries, but please undo those changes.

Otherwise, everything looks good.
Thank you for your contribution! Just clear up that one commit, and this will be ready for merging.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Apr 16, 2025
Copy link
Member

@andyvu923 andyvu923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Christopher-Chhim , thanks for tackling this issue.

Things done well

Suggested changes

As mentioned above, a commit from another issue you worked on ( #7484 ) seems to be added to this PR. To avoid confusion, this commit should be removed from this PR.

Once these changes are made, please re-request a review from me. Thank you once again!

@kdaca19xx
Copy link
Member

kdaca19xx commented Apr 20, 2025

Availability: after 1pm (pacific)
ETA: 4/25

kdaca19xx

This comment was marked as resolved.

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right on, Christopher!

Things Done Well

  • The pull request done with the correct branch.
  • There's a linked issue, and I understand it.
  • I took a look at files changed tab and read the comments about the Emily Eldar deletion.
  • I could see the changes in the browser (Thanks againg, Mugdh!)

Suggestions

I'm not sure what to suggest beyond what other's have already said.

@andyvu923
Copy link
Member

Also ran on the browser and everything works as expected. PR approved 👍👍

@TheManTheMythTheGameDev
Copy link
Member

@Christopher-Chhim I see that you made new commits, but the extra changes still appear in the "Files Changed" tab.
For what it's worth, the extraneous changes were already merged separately, so this should merge without any issues. However, it's not great practice.
@andyvu923 May I ask why you chose to approve this PR?

I'm unsure whether to approve this or not -- an extra file is changed, but merging it shouldn't cause any harm.

@andyvu923
Copy link
Member

@TheManTheMythTheGameDev just read your comment and yeah, I see the file changes now. I probably missed it while doing my re-review.

It does seem like merging this PR won't cause any issues, and I did recheck both files that were changed on my local machine to see if any unwanted changes were present, but everything does appear to be functioning normally. Based purely on functionality, this PR seems to be good, but the extra file changes definitely should be removed if able. However, I'm not entirely sure what suggestions I could make to fix this issue.

@LRenDO
Copy link
Member

LRenDO commented May 1, 2025

Hi @Christopher-Chhim! Please try pulling the changes from gh-pages into your branch and push the branch again. I believe this should resolve why the changes from your old PR are showing here. Thanks!

@t-will-gillis
Copy link
Member

Hi @Christopher-Chhim Please respond to the comments above as soon as possible to let us know that you intend to complete this PR, and let us know if you need assistance. If we don't hear from you soon, we will assume that you are no longer working on this. Thanks

@t-will-gillis
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: 311 Data Remove Anna Kim
7 participants