Skip to content

Update Project Profile: Civic Tech Jobs Remove Leah Ellis #8114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

rleeoriginal
Copy link
Member

@rleeoriginal rleeoriginal commented May 3, 2025

Fixes #7737

What changes did you make?

  • Removed Leah Ellis from _projects/civic-tech-jobs.md under the leadership section

Why did you make the changes (we will use this info to test)?

  • To keep the website's project profile accurate and up-to-date.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

github-actions bot commented May 3, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b rleeoriginal-remove-leah-ellis-7737 gh-pages
git pull https://github.com/rleeoriginal/website.git remove-leah-ellis-7737

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 3, 2025
@katiejnete katiejnete self-requested a review May 4, 2025 04:31
@katiejnete
Copy link
Member

ETA: EOD
Availability: Saturday

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rleeoriginal , thank you for taking on this issue.

Things you did well:

  • PR is done with the correct branch.
  • PR contains correctly formatted linked issue.
  • CodeQL Alerts have been properly checked.
  • Before and after screenshots are appropriately included.
  • The changes are applicable to the issue.
  • Website is still user-friendly and links and components still work as intended.
  • Source code changes are applicable and clean.

Suggested changes:

  • Please remove first paragraph from this PR.
  • Please remove (lines [insert line numbers here]) from the "What changes did you make?" section.

Notes:

  • Backticks (`) can be used to format short snippets of code. _projects/civic-tech-jobs.md

Please re-request a review from me after making suggested changes. Thank you for your hard work!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board May 4, 2025
@kdaca19xx kdaca19xx self-requested a review May 4, 2025 22:27
@rleeoriginal rleeoriginal requested a review from katiejnete May 5, 2025 01:23
Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes! I approve this PR.

@kdaca19xx
Copy link
Member

Availability: after 1pm (pacific)
ETA: 5/6

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That right there, rleeoriginal!

Things Done Well

  • The pull request done with the correct branch.
  • There's a linked issue, and I understand it.
  • I appreciated the file name and path provided under "What changes did you make?"
  • I took a look at files changed tab, and I viewed the changes in the browser.

Suggestions

Keep up the great work!

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 7, 2025
@LRenDO LRenDO merged commit 3312e7a into hackforla:gh-pages May 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs Remove Leah Ellis
4 participants