-
-
Notifications
You must be signed in to change notification settings - Fork 830
Update Project Profile: Civic Tech Jobs Remove Leah Ellis #8114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rleeoriginal , thank you for taking on this issue.
Things you did well:
- PR is done with the correct branch.
- PR contains correctly formatted linked issue.
- CodeQL Alerts have been properly checked.
- Before and after screenshots are appropriately included.
- The changes are applicable to the issue.
- Website is still user-friendly and links and components still work as intended.
- Source code changes are applicable and clean.
Suggested changes:
- Please remove first paragraph from this PR.
- Please remove
(lines [insert line numbers here])
from the "What changes did you make?" section.
Notes:
- Backticks (`) can be used to format short snippets of code.
_projects/civic-tech-jobs.md
Please re-request a review from me after making suggested changes. Thank you for your hard work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes! I approve this PR.
Availability: after 1pm (pacific) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That right there, rleeoriginal!
Things Done Well
- The pull request done with the correct branch.
- There's a linked issue, and I understand it.
- I appreciated the file name and path provided under "What changes did you make?"
- I took a look at files changed tab, and I viewed the changes in the browser.
Suggestions
Keep up the great work!
Fixes #7737
What changes did you make?
_projects/civic-tech-jobs.md
under the leadership sectionWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied