feat: add sensitive_request_headers argument
#521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This seeks to address issue hashicorp#34 via `sensitive_request_headers`, which serves the same function as `request_headers`, but are denoted as sensitive and their values are obscured as `*****` in Terraform state. Signed-off-by: Mike Ball <[email protected]>
mdb
force-pushed
the
mdb/sensitive-request-headers
branch
from
e1b4a01 to
0d4aa69
Compare
mdb
commented
Apr 16, 2025
| if strings.ToLower(name) == "host" { | ||
| request.Host = header | ||
| } | ||
| } |
There was a problem hiding this comment.
☝️ This and the line 348 loop could probably be DRY'd up :)
|
Hi @mdb 👋
Does wrapping your secret value in |
|
Hi @ansgarm - Thanks for the response!
I don't believe so;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seeks to address issue #34 via
sensitive_request_headers, which serves the same function asrequest_headers, butsensitive_request_headersare denoted as sensitive and their values are obscured as*****in Terraform state.