-
Notifications
You must be signed in to change notification settings - Fork 2
Add Version 2 request support to Natural Language API documentation #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@rakeshkky Thanks for your PR! I've assigned @seanparkross to review it. |
Deploying promptql-docs with
|
Latest commit: |
9196da6
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e597eca2.promptql-docs.pages.dev |
Branch Preview URL: | https://rakeshkky-promptql-api-v2-do.promptql-docs.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few questions / suggestions
- **Version 1 (v1)**: Uses direct DDN URL configuration with optional LLM settings | ||
- **Version 2 (v2)**: Uses DDN build-based configuration with settings from build metadata | ||
|
||
### Request v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put v1 and v2 in tabs? Is it a case of it's normally one or the other or will a user ever use both versions together? I can set up the tabs if yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Thank you.
Co-authored-by: Sean Park-Ross <[email protected]>
Co-authored-by: Sean Park-Ross <[email protected]>
Description 📝
This PR enhances the Natural Language API documentation by adding comprehensive support for Version 2 (v2) requests alongside the existing Version 1 (v1) documentation.
Key changes:
Quick Links 🚀
Assertion Tests 🤖