Skip to content

downgrade react 18, fix markdown, fix #6 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2024
Merged

downgrade react 18, fix markdown, fix #6 #7

merged 1 commit into from
Dec 31, 2024

Conversation

heimoshuiyu
Copy link
Owner

@heimoshuiyu heimoshuiyu commented Dec 31, 2024

fix issue #6

@heimoshuiyu heimoshuiyu requested a review from ecwu December 31, 2024 04:03
@ecwu
Copy link
Collaborator

ecwu commented Dec 31, 2024

Is it possible to maintain the current React version (19+) and switch to a different markdown rendering package?

@heimoshuiyu
Copy link
Owner Author

Currently, we are using react-markdown, which appears at the top of search engine results. Therefore, I assume it is the most popular markdown renderer. Another option is the react-mde markdown editor, but it requires React 17. Do you know of any markdown rendering frameworks that currently support React 19?

@ecwu
Copy link
Collaborator

ecwu commented Dec 31, 2024

I searched around and found that there really isn't a direct and convenient option. I noticed that React-markdown's support for React 19 is already in the CR stage. I suggest waiting for the patch to be merged and then updating the package.

@heimoshuiyu heimoshuiyu merged commit 8192649 into master Dec 31, 2024
@heimoshuiyu heimoshuiyu deleted the react-18 branch January 4, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants