refactor(statusline): add hint and info for non-workspace diagnostics

[RoloEdits]

This adds info and hint diagnostics indicators to the existing warning and error. Besides having more info for the current code you are looking at, this also opens up changing the fallback accumulator being to hint now, instead of error. In cases where LSPs improperly handle diagnostic level declaration, this now prevents an error being declared across both the current buffer as well as the workspace (I have removed the fallback accumulator for the workspace). This should hopefully help reduce noise.

[the-mikedavis]

IIRC it's only warnings and errors now so that the component doesn't take up much space. Adding hints + info makes it fairly wide

[the-mikedavis]

To be consistent we should probably use diag.severity() here so that None becomes Warning -

helix/helix-core/src/diagnostic.rs

Lines 97 to 102 in efdcf34

	impl Diagnostic {
	#[inline]
	pub fn severity(&self) -> Severity {
	self.severity.unwrap_or(Severity::Warning)
	}
	}

[RoloEdits]

Is there a reason Warning was chosen and not something else like Hint?

[the-mikedavis]

I'm not sure of the context of it. It does make some sense to me that the "default" state of a diagnostic is a warning. I don't think it's very common that language servers omit the severity anyways

[RoloEdits]

I wonder if there would be a nice way to have a min severity like how inline diagnostics have? The default would be to keep warning. But then you can change to "hint" or "info" (or even just "error").

[editor.statusline]
min-diagnostic-severity = "hint"

[the-mikedavis]

Superseded by #13288