-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic language support for Fennel. Might even work. #13260
base: master
Are you sure you want to change the base?
Conversation
Closes helix-editor#3846 . There are two different tree-sitter parsers for Fennel mentioned in that issue: * https://github.com/travonted/tree-sitter-fennel * https://github.com/alexmozaidze/tree-sitter-fennel This PR has arbitrarily chosen the second one. There's also several different `highlights.scm` options, I've mostly chosen the most recent one but tried to incorporate bits and pieces from the others.
also need to add |
Added, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can run cargo xtask docgen
and commit the changes to fix the docs CI.
Might even work.
I realize this statement is probably meant as a joke but you have tested this patch, right? You can use cargo run
to run a debug build which will use these queries.
languages.toml
Outdated
[[grammar]] | ||
name = "fennel" | ||
source.git = "https://github.com/alexmozaidze/tree-sitter-fennel" | ||
source.rev = "ea4a536bca8997e30b22709f210f44f97e75bf7d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this revision is fairly old. Is there any reason not to use the latest commit?
Co-authored-by: Michael Davis <[email protected]>
Co-authored-by: uncenter <[email protected]>
Jokes aside, yes I've tested it, but probably not as thoroughly as I should. Lots of my PR's come out of catharsis and then get mopped up after the fact if it turns out that anyone is actually interested in them. I swear I got this to work via some kind of cursed flailing around, but upon trying again to do it
Off to a good start? |
I'm getting this cryptic log error, of which I've seen before and not exactly sure how to solve 😓
|
Closes #3846 . After pondering it (for two years) it seems obvious that having a single grammar that tries to cover multiple Lisps is silly.
There are two different tree-sitter parsers for Fennel mentioned in that issue:
This PR has mostly-arbitrarily chosen the second one. There's also several different
highlights.scm
options, I've mostly chosen the most recent one but tried to incorporate bits and pieces from the others where I could find them.