switch to crate arm_pl031 to read the realtime clock #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlankes
force-pushed
the
pl031
branch
3 times, most recently
from
934645e to
c1143d6
Compare
stlankes
force-pushed
the
pl031
branch
2 times, most recently
from
6582062 to
60e7106
Compare
jounathaen
reviewed
Apr 28, 2025
src/arch/aarch64/kernel/processor.rs
Outdated
| @@ -221,27 +207,14 @@ pub fn detect_frequency() { | |||
| fn __set_oneshot_timer(wakeup_time: Option<u64>) { | |||
| if let Some(wt) = wakeup_time { | |||
| // wt is the absolute wakeup time in microseconds based on processor::get_timer_ticks. | |||
| let deadline = u128::from(wt) * u128::from(CPU_FREQUENCY.get()) / 1_000_000; | |||
| let deadline = u64::try_from(deadline).unwrap(); | |||
| let deadline = (wt * u64::from(get_frequency())) / 1000; | |||
There was a problem hiding this comment.
I assume this is fine, but I'd suggest double-checking that a u64 is sufficient here (was u128 before).
There was a problem hiding this comment.
move this part to #1703
|
In general: LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the application is running on top of Qemu, the ARM PrimeCell Real Time Clock(PL031) can be used to determine the boot time. By this patch, the crate arm_pl031 is used as interface to the real time clock.
uhyve doesn't support the real-time clock. To detemine the unix timestamp, the boot time from bootinfo is used