Skip to content

fix(tuple): Repeat tupple type maxItems times #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Conversation

sredni
Copy link

@sredni sredni commented Apr 12, 2025

For now tuple type creates one item ignoring actual number of items.

Copy link

stackblitz bot commented Apr 12, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Apr 12, 2025

🦋 Changeset detected

Latest commit: 2a03e37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@test/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 5:31pm

@mrlubos
Copy link
Member

mrlubos commented Apr 12, 2025

Hey @sredni can you update snapshots please? That should cover my ask which would've been to add tests

@sredni
Copy link
Author

sredni commented Apr 12, 2025

yepp, I'm working on that, will let you know when will be fixed.

Copy link

pkg-pr-new bot commented Apr 13, 2025

Open in StackBlitz

@hey-api/client-axios

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-axios@1938

@hey-api/client-fetch

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-fetch@1938

@hey-api/client-next

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-next@1938

@hey-api/client-nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-nuxt@1938

@hey-api/nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@1938

@hey-api/openapi-ts

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@1938

@hey-api/vite-plugin

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@1938

commit: 2a03e37

Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.34%. Comparing base (fe9a70b) to head (2a03e37).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/ir/schema.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1938   +/-   ##
=======================================
  Coverage   22.34%   22.34%           
=======================================
  Files         251      251           
  Lines       21026    21026           
  Branches      781      781           
=======================================
  Hits         4699     4699           
  Misses      16321    16321           
  Partials        6        6           
Flag Coverage Δ
unittests 22.34% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sredni
Copy link
Author

sredni commented Apr 15, 2025

@mrlubos can you check now?

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! 😎 thank you

@sredni
Copy link
Author

sredni commented Apr 16, 2025

any chance to have it merged?

@mrlubos
Copy link
Member

mrlubos commented Apr 17, 2025

@sredni yes sir! coming up, had to fix something else first, sorry for the delay!

@mrlubos mrlubos merged commit 15de33f into hey-api:main Apr 17, 2025
15 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants