Publish to bcr config #1
Conversation
.bcr/presubmit.yml
Outdated
| bazel: ${{ bazel }} | ||
| test_targets: | ||
| - "//examples/internal/..." | ||
| - "//:all" |
There was a problem hiding this comment.
This target does not exist, and I don't know if it makes sense to add this when we only really want to build the examples.
| - "//:all" |
| @@ -0,0 +1,13 @@ | |||
| bcr_test_module: | |||
| module_path: "MODULE.bazel" | |||
There was a problem hiding this comment.
If I recall our original conversation correctly, we were discussing the possibility of creating a small test project within the grpc-gateway repo to run the pre-submit with. This project would import the grpc-gateway Bazel module and build the examples with it. That way, we would be testing the entire bzlmod pipeline.
If that is the case, we would have to create a MODULE.bazel file in the examples directory and configure it to import the grpc-gateway Bazel module, and update this configuration so to import that module instead.
| module_path: "MODULE.bazel" | |
| module_path: "examples/MODULE.bazel" |
At this point, you are probably better informed than I am as to how to proceed with the pre-submit check, but I didn't want to approve without asking if the current configuration is intentional.
|
Thanks for looking into this, please let me know what, if anything, you need me to help with. |
hharrisd
force-pushed
the
publish-to-bcr-config
branch
from
2a698f3 to
5826a0c
Compare
References to other Issues or PRs
This is a follow-up work for the issue: Consider publishing grpc-gateway to Bazel Central Registry #5183
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
This PR aims to add the templates for the Publish to the Bazel Central Registry - BCR process.
The process is described in bazel-contrib/publish-to-bcr
Other comments