-
Notifications
You must be signed in to change notification settings - Fork 214
feat(faq-inquiries): Add user association and delete functionality #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
… FAQ inquiries, added tests for the delete endpoint
… the faq_inquiries Added a mock JWT token for Bearer authentication in test requests Updated `AUTH_HEADERS` to include the mock token Ensured the token is used in POST `/faq-inquiries` and `DELETE /faq-inquiries/{id}` tests Improved test reliability by simulating authenticated requests
Signed-off-by: Bobbysam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think attaching user id to faq is a good idea??
can i modify the middleware in this format to allow public routes that doesn't need token ???
|
There's no need for that Middleware in the first place |
|
Hi joedev i have made use of dependency and removed the middleware |
Delete FAQ and Add User ID to FAQ
Description
This PR implements two changes:
DELETE
/api/v1/faq-inquiries/{id}
user_id
field, ensuring FAQs are associated with a specific user.Related Issue (Link to issue ticket)
Motivation and Context
How Has This Been Tested?
user_id
is correctly stored and retrieved.Screenshots (if appropriate - Postman, etc):
Types of changes
Checklist: