feat: retrieve top rated testimonials #1171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemando
changed the title
mikemando
changed the title
samuelogboye
previously approved these changes
Mar 1, 2025
api/v1/services/testimonial.py
Outdated
Comment on lines
64
to
66
| if page < 1 or per_page < 1: | ||
| raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail="Invalid pagination parameters") | ||
|
|
There was a problem hiding this comment.
Instead of manually checking page < 1 or per_page < 1, FastAPI's Query parameters already enforce the constraints (ge=1), so this check is redundant.
Comment on lines
33
to
39
| db_session_mock.query().order_by().offset().limit().all.return_value = [mock_testimonial] | ||
|
|
||
| response = client.get("/api/v1/testimonials/top-rated", params={"page": 1, "per_page": 1}) | ||
|
|
||
| assert response.status_code == 200 | ||
| assert response.json()["message"] == "Top-rated testimonials retrieved successfully." | ||
| assert len(response.json()["data"]) == 1 |
There was a problem hiding this comment.
Add tests for edge cases like
No testimonials in the database, Invalid page or per_page parameters, Database failure scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new API endpoint
/api/v1/testimonials/top-ratedthat allows users to retrieve testimonials sorted by rating. It also includes a unit test to ensure the API works as expected.
Related Issue (Link to issue ticket)
closes #1142
Motivation and Context
How Has This Been Tested?
test_get_top_rated_api) usingpytestandunittest.mock.MagicMock.
Screenshots (if appropriate - Postman, etc):
Types of changes
Checklist: