-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Kulersky refactor to new Bluetooth subsystem #142309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! Welcome back 🎉 Looks like the link to the changelog is pointing at the wrong location. |
Whoops! Just fixed that. |
Feel free to reach out on discord (bdraco) when you need a followup review. If your handle is different than here, please post your handle or drop me an email with it so I know to accept messages. |
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @emlove
Proposed change
👋🏻 It's been a while!
This PR updates the kulersky component to use the core Bluetooth system instead of setting up its own Bleak scanner. This means that these devices can now be automatically discovered!
Upstream changelog: https://github.com/emlove/pykulersky?tab=readme-ov-file#changelog
The biggest upstream change is that it now allows a BLEDevice to be passed down to the underlying BleakClient so that it can take advantage of the BLEDevice from the hass bluetooth component.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: