Skip to content

Kulersky refactor to new Bluetooth subsystem #142309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 14, 2025
Merged

Kulersky refactor to new Bluetooth subsystem #142309

merged 18 commits into from
Apr 14, 2025

Conversation

emlove
Copy link
Contributor

@emlove emlove commented Apr 4, 2025

Proposed change

👋🏻 It's been a while!

This PR updates the kulersky component to use the core Bluetooth system instead of setting up its own Bleak scanner. This means that these devices can now be automatically discovered!

Upstream changelog: https://github.com/emlove/pykulersky?tab=readme-ov-file#changelog

The biggest upstream change is that it now allows a BLEDevice to be passed down to the underlying BleakClient so that it can take advantage of the BLEDevice from the hass bluetooth component.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emlove emlove mentioned this pull request Apr 5, 2025
19 tasks
@balloob
Copy link
Member

balloob commented Apr 5, 2025

Hi! Welcome back 🎉

Looks like the link to the changelog is pointing at the wrong location.

@emlove
Copy link
Contributor Author

emlove commented Apr 5, 2025

Whoops! Just fixed that.

@bdraco bdraco self-requested a review April 5, 2025 01:24
@bdraco
Copy link
Member

bdraco commented Apr 6, 2025

Feel free to reach out on discord (bdraco) when you need a followup review.

If your handle is different than here, please post your handle or drop me an email with it so I know to accept messages.

@bdraco bdraco self-requested a review April 8, 2025 01:03
@bdraco bdraco removed the dependency label Apr 8, 2025
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emlove

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Apr 9, 2025
@frenck frenck merged commit d44d07f into dev Apr 14, 2025
48 checks passed
@frenck frenck deleted the kulersky-refactor branch April 14, 2025 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants