-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Create Squeezebox initial Quality Scale entry #142427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Hey there @rajlaud, @pssc, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
HI @MartinHjelmare. Could you add the code-quality label pls - forgot to tick it when I created the PR, and updating the comment doesn't add the label now. |
@home-assistant add-label code-quality |
Proposed change
This PR adds the initial Quality Scale entry for the Squeezebox integration
Bronze
action-setup
- Service actions are registered in async_setupappropriate-polling
- If it's a polling integration, set an appropriate polling intervalbrands
- Has branding assets available for the integrationcommon-modules
- Place common patterns in common modulesconfig-flow-test-coverage
- Full test coverage for the config flowconfig-flow
- Integration needs to be able to be set up via the UIdata_description
to give context to fieldsConfigEntry.data
andConfigEntry.options
correctlydependency-transparency
- Dependency transparencydocs-actions
- The documentation describes the provided service actions that can be useddocs-high-level-description
- The documentation includes a high-level description of the integration brand, product, or servicedocs-installation-instructions
- The documentation provides step-by-step installation instructions for the integration, including, if needed, prerequisitesdocs-removal-instructions
- The documentation provides removal instructionsentity-event-setup
- Entities event setupentity-unique-id
- Entities have a unique IDhas-entity-name
- Entities use has_entity_name = Trueruntime-data
- Use ConfigEntry.runtime_data to store runtime datatest-before-configure
- Test a connection in the config flowtest-before-setup
- Check during integration initialization if we are able to set it up correctlyunique-config-entry
- Don't allow the same device or service to be able to be set up twiceSilver
action-exceptions
- Service actions raise exceptions when encountering failuresconfig-entry-unloading
- Support config entry unloadingdocs-configuration-parameters
- The documentation describes all integration configuration optionsdocs-installation-parameters
- The documentation describes all integration installation parametersentity-unavailable
- Mark entity unavailable if appropriateintegration-owner
- Has an integration ownerlog-when-unavailable
- If internet/device/service is unavailable, log once when unavailable and once when back connectedparallel-updates
- Set Parallel updatesreauthentication-flow
- Reauthentication flowtest-coverage
- Above 95% test coverage for all integration modulesGold
devices
- The integration creates devicesdiagnostics
- Implements diagnosticsdiscovery-update-info
- Integration uses discovery info to update network informationdiscovery
- Can be discovereddocs-data-update
- The documentation describes how data is updateddocs-examples
- The documentation provides automation examples the user can use.docs-known-limitations
- The documentation describes known limitations of the integration (not to be confused with bugs)docs-supported-devices
- The documentation describes known supported / unsupported devicesdocs-supported-functions
- The documentation describes the supported functionality, including entities, and platformsdocs-troubleshooting
- The documentation provides troubleshooting informationdocs-use-cases
- The documentation describes use cases to illustrate how this integration can be useddynamic-devices
- Devices added after integration setupentity-category
- Entities are assigned an appropriate EntityCategoryentity-device-class
- Entities use device classes where possibleentity-disabled-by-default
- Integration disables less popular (or noisy) entitiesentity-translations
- Entities have translated namesexception-translations
- Exception messages are translatableicon-translations
- Icon translationsreconfiguration-flow
- Integrations should have a reconfigure flowrepair-issues
- Repair issues and repair flows are used when user intervention is neededstale-devices
- Clean up stale devicesPlatinum
async-dependency
- Dependency is asyncinject-websession
- The integration dependency supports passing in a websessionstrict-typing
- Strict typingType of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: