Refactor Whirlpool sensor tests #142437
Open
Refactor Whirlpool sensor tests #142437
+736
−364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: whirlpool
small-pr
|
Hey there @mkmer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tests/components/whirlpool/snapshots/test_diagnostics.ambr: Language not supported
- tests/components/whirlpool/snapshots/test_sensor.ambr: Language not supported
joostlek
reviewed
Apr 9, 2025
| 'unit_of_measurement': None, | ||
| }) | ||
| # --- | ||
| # name: test_all_entities[sensor.dryer_none-state] |
joostlek
reviewed
Apr 9, 2025
Comment on lines
+26
to
+33
| @pytest.fixture | ||
| def entity_registry_enabled_by_default() -> Generator[None]: | ||
| """Test fixture that ensures entities are enabled in the registry.""" | ||
| with mock.patch( | ||
| "homeassistant.components.whirlpool.sensor.WhirlpoolSensor.entity_registry_enabled_default", | ||
| return_value=True, | ||
| ): | ||
| yield |
There was a problem hiding this comment.
this one already exists
@pytest.mark.usefixtures("entity_registry_enabled_by_default")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This is a full rewrite of the sensor platform tests in an attempt to make them easier to maintain and support new sensors in the future.
mock_sensor*fixtures, tomock_washerandmock_dryersince in the future other types of appliances may have sensors too.These changes should also make it easier to add and test new sensors if they are simple, since only snapshots need to be updated.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: