-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Add support for sending keyboard text to Android TV Remote #142438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Hey there @Drafteed, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
device = kwargs.get(ATTR_DEVICE) | ||
if device and device != "keyboard": | ||
raise HomeAssistantError( | ||
translation_domain=DOMAIN, | ||
translation_key="send_command_invalid_device", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be more clear as a separate/dedicated service action?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Breaking change
Proposed change
Add support for sending text to an Android TV Remote via the
remote.send_command
action anddevice: keyboard
.This is an alternative to #139033
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: