Delay stream startup #142447
Open
Delay stream startup #142447
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
dependency
integration: teslemetry
new-feature
small-pr
|
Test failures seem unrelated. |
erwindouna
reviewed
Apr 7, 2025
erwindouna
reviewed
Apr 9, 2025
| @@ -290,7 +289,7 @@ def _async_value_from_stream(self, value: Any) -> None: | |||
| """Update the entity with the latest value from the stream.""" | |||
| raise NotImplementedError | |||
|
|
|||
| @cached_property | |||
| @property | |||
There was a problem hiding this comment.
Why is it changed from cached_property to property?
There was a problem hiding this comment.
This is a bug that has only became apparent due to the change in stream behaviour. The cached property was not changing when the stream connected property changes. Making it a non cached property fixed this.
erwindouna
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Teslemetry stream sends cached data on connection, but since the stream was starting before platforms had loaded, this data was lost. This changes the stream to only start after all platforms have loaded, so that no data is lost at startup.
Teslemetry/python-teslemetry-stream@v0.7.1...v0.7.2
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: