-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add note on flash endurance for APsystems integration #38313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note on flash endurance for APsystems integration #38313
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughA new "Flash Endurance" section has been added to the APsystems integration documentation. This section describes the impact of using the Changes
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/apsystems.markdown (2)
56-56
: Markdown Formatting: Ensure Blank Lines Around HeadingsThe heading "## Flash Endurance" should be surrounded by blank lines to comply with markdown style guidelines (MD022). Please ensure there's a blank line immediately before and after the heading.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
56-56: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
57-57
: Grammar and Typographical Corrections: Fix Number Agreement and SpellingThere are a couple of minor issues in the added flash endurance note:
- Replace "newer hardware version don't have this issue" with "newer hardware versions don't have this issue" to correct subject-verb agreement.
- Correct "moer frequently" to "more frequently".
A suggested diff:
-APsystems officially confirmed this to me, while also acknowledging that newer hardware version don't have this issue, while older ones should be updated at most every 300 seconds. Newer inverters have a serial number starting with `Ex701` and thus aren't at risk of flash wear when setting the `output_limit` moer frequently than every 300 seconds. +APsystems officially confirmed this to me, while also acknowledging that newer hardware versions don't have this issue, while older ones should be updated at most every 300 seconds. Newer inverters have a serial number starting with `Ex701` and thus aren't at risk of flash wear when setting the `output_limit` more frequently than every 300 seconds.🧰 Tools
🪛 LanguageTool
[grammar] ~57-~57: There seems to be a noun/verb agreement error (not necessarily with the noun that is immediately before ‘version’).
Context: ...knowledging that newer hardware version don't have this issue, while older ones shoul...(SINGULAR_NOUN_AGREEMENT_DONT)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/apsystems.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/apsystems.markdown
[grammar] ~57-~57: There seems to be a noun/verb agreement error (not necessarily with the noun that is immediately before ‘version’).
Context: ...knowledging that newer hardware version don't have this issue, while older ones shoul...
(SINGULAR_NOUN_AGREEMENT_DONT)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/apsystems.markdown
56-56: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
Alright, wasn't sure if I should include this part, but you answered my question ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mawoka-myblock 👍
../Frenck
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit