-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
KNX Cover entity configuration from UI #38319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis update enhances the KNX integration documentation by clarifying the configuration of KNX cover entities. The changes specify that cover entities can be created either via the frontend KNX panel or through YAML configuration. A new section titled "Configuration of KNX cover entities via YAML" was added, including an example YAML snippet and the corresponding closing tag. Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/knx.markdown (1)
1067-1069
: Clarify Cover Entity Configuration Options
The new line explicitly informs users that cover entities can be created either via the KNX panel (UI) or through YAML. This succinct statement is helpful; however, consider adding a link or brief indication on where to find more details about the UI process if available.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/knx.markdown
(2 hunks)
🔇 Additional comments (1)
source/_integrations/knx.markdown (1)
1070-1087
: Comprehensive YAML Example for KNX Cover Entities
The new details block titled "Configuration of KNX cover entities via YAML" provides a clear and structured YAML example. The parameters (such asmove_long_address
,move_short_address
,stop_address
,position_address
,position_state_address
, and the travelling time settings) align well with the patterns used in other platform sections. Please verify that these parameter names are consistent with those used across the documentation and the Home Assistant integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
KNX Cover entity configuration from UI
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Add support to create KNX Cover entities from UI core#141944
Checklist
current
branch.next
branch.Summary by CodeRabbit