Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for the Legrand Whole House Lighting integration #38339

Closed
wants to merge 4 commits into from

Conversation

bas-tard
Copy link

@bas-tard bas-tard commented Apr 2, 2025

Proposed change

Adding a markdown file for a new integration.
Pull request: home-assistant/core#141963

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Documentation
    • Introduced a comprehensive guide for integrating Legrand Whole House Lighting with Home Assistant, covering setup prerequisites, detailed configuration steps, troubleshooting tips, and instructions for removal.
  • New Features
    • Added new words to the spell checker: "Legrand" and "tard".

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 2, 2025
@home-assistant
Copy link

home-assistant bot commented Apr 2, 2025

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit eb4b864
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67ef0fbccce1bd00088c9a9d
😎 Deploy Preview https://deploy-preview-38339--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 2, 2025

📝 Walkthrough

Walkthrough

The changes include an update to the cSpell configuration and the addition of new integration documentation. The .vscode/cSpell.json file now includes two additional words ("Legrand" and "tard") in the words array. In addition, a new markdown file has been added in the integrations folder to document the Legrand Whole House Lighting integration for Home Assistant, detailing its setup, configuration parameters, and troubleshooting instructions.

Changes

File(s) Change Summary
.vscode/cSpell.json Added two words ("Legrand" after "laundrify" and "tard" after "statestream") to the words array.
source/_integrations/lc7001.markdown New file added documenting the Legrand Whole House Lighting integration; includes metadata, setup prerequisites, configuration parameters, and troubleshooting procedures.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant HA as Home Assistant
    participant LD as Legrand Device

    U->>HA: Configure Legrand Integration
    HA->>LD: Establish connection (host, port, password)
    alt Connection Successful
        LD-->>HA: Acknowledge connection\nand provide device details
        HA-->>U: Activate integration (lights & dimmers set up)
    else Connection Failed
        LD-->>HA: Return error response
        HA-->>U: Display troubleshooting guidance
    end
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2376c8a and eb4b864.

📒 Files selected for processing (1)
  • source/_integrations/lc7001.markdown (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • source/_integrations/lc7001.markdown

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
source/_integrations/lc7001.markdown (2)

24-24: Nitpick: Markdown Formatting – Trailing Space and Bare URL
There is a trailing space at the end of this line and the bare URL (https://www.mycompany.com) does not have descriptive link text. Consider removing the trailing space and either providing a label for the URL or rewriting the link for clarity.

-The Legrand Whole House Lighting {% term integration %} is used to integrate with the devices of [[Legrand](https://www.legrand.ca/wiring-devices/electrical-accessories/miscellaneous/discontinued-whole-house-lighting-controller/p/lc7001)](https://www.mycompany.com). 
+The Legrand Whole House Lighting {% term integration %} is used to integrate with the devices of [[Legrand](https://www.legrand.ca/wiring-devices/electrical-accessories/miscellaneous/discontinued-whole-house-lighting-controller/p/lc7001)](https://www.mycompany.com).
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

24-24: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


24-24: Bare URL used
null

(MD034, no-bare-urls)


36-37: Suggestion: Rephrase Instruction for Clarity
The instruction "Set-up your system with the app." is better written as "Set up your system with the app." to properly use the verb form.

-2. Set-up your system with the app.
+2. Set up your system with the app.
🧰 Tools
🪛 LanguageTool

[grammar] ~37-~37: This sentence should probably be started with a verb instead of the noun ‘Set-up’. If not, consider inserting a comma for better clarity.
Context: ...he Legrand Lighting Control app. 2. Set-up your system with the app. {% include i...

(SENT_START_NN_DT)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9924b68 and 2376c8a.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .vscode/cSpell.json (2 hunks)
  • source/_integrations/lc7001.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/lc7001.markdown

[grammar] ~37-~37: This sentence should probably be started with a verb instead of the noun ‘Set-up’. If not, consider inserting a comma for better clarity.
Context: ...he Legrand Lighting Control app. 2. Set-up your system with the app. {% include i...

(SENT_START_NN_DT)

🪛 markdownlint-cli2 (0.17.2)
source/_integrations/lc7001.markdown

24-24: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


24-24: Bare URL used
null

(MD034, no-bare-urls)

🔇 Additional comments (5)
.vscode/cSpell.json (2)

57-57: Approved: Inclusion of "Legrand" in spell check dictionary
Adding "Legrand" prevents false positives for the new integration documentation and ensures consistency in terminology.


83-83: Approved: Inclusion of "tard" in spell check dictionary
Adding "tard" accommodates the code owner’s username and avoids unwanted spell check flags. Please ensure this is intentional.

source/_integrations/lc7001.markdown (3)

1-22: Approved: Well-Structured YAML Front Matter
The YAML header is complete and clear. It correctly specifies metadata such as title, description, release version, code owners, and platforms, which aligns with Home Assistant’s integration documentation standards.


39-48: Approved: Inclusion of Configuration Block
The configuration block (lines 39–48) using Liquid templating is well integrated and follows the conventions used in Home Assistant documentation for configuration instructions.


50-87: Approved: Comprehensive Integration Documentation
The remaining sections—including supported devices, prerequisites, supported functionality, troubleshooting, and removal instructions—are detailed and clear. They provide thorough guidance for the end user in line with Home Assistant’s documentation standards.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

87-87: Multiple consecutive blank lines
Expected: 1; Actual: 2

(MD012, no-multiple-blanks)

@home-assistant home-assistant bot closed this Apr 7, 2025
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Apr 7, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Documentation PRs Apr 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant