Skip to content

Move magic item execution out of API file #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Move magic item execution out of API file #3507

merged 1 commit into from
Mar 27, 2025

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Mar 27, 2025

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal added watch The Apple Watch app and complications widgets shortcuts labels Mar 27, 2025
@bgoncal bgoncal self-assigned this Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 83 lines in your changes missing coverage. Please review.

Project coverage is 45.33%. Comparing base (c038f38) to head (f217489).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
Sources/Shared/MagicItem/MagicItem.swift 0.00% 79 Missing ⚠️
Sources/Shared/API/AppTriggerSource.swift 0.00% 2 Missing ⚠️
Sources/Shared/API/Models/Action.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3507      +/-   ##
==========================================
- Coverage   45.51%   45.33%   -0.18%     
==========================================
  Files         224      225       +1     
  Lines       13353    13390      +37     
==========================================
- Hits         6078     6071       -7     
- Misses       7275     7319      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bgoncal bgoncal merged commit b70242c into master Mar 27, 2025
13 checks passed
@bgoncal bgoncal deleted the magic-item-run branch March 27, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed shortcuts watch The Apple Watch app and complications widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant