Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and migrate onboarding screens to SwiftUI #3527

Merged
merged 21 commits into from
Apr 8, 2025
Merged

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Apr 7, 2025

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

onboarding-low.mov

@bgoncal bgoncal self-assigned this Apr 7, 2025
@bgoncal bgoncal requested a review from a team April 7, 2025 15:32
Copy link

emerge-tools bot commented Apr 7, 2025

1 build increased size

Name Version Download Change Install Change Approval
Home Assistant
io.robbie.HomeAssistant
2025.4 (2025.4847) 60.3 MB ⬆️ 131.0 kB (0.22%) 129.0 MB ⬆️ 239.6 kB (0.19%) N/A

Home Assistant 2025.4 (2025.4847)
io.robbie.HomeAssistant

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 239.6 kB (0.19%)
Total download size change: ⬆️ 131.0 kB (0.22%)

Largest size changes

Item Install Size Change
Shared ⬆️ 61.4 kB
📝 logo-horizontal-text-dark.png ⬆️ 17.3 kB
🗑 HomeAssistant.OnboardingManualURLViewController ⬇️ -17.2 kB
🗑 HomeAssistant.OnboardingScanningViewController ⬇️ -16.7 kB
📝 logo-horizontal-text.png ⬆️ 16.4 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 49.45652% with 93 lines in your changes missing coverage. Please review.

Project coverage is 45.75%. Comparing base (99c6596) to head (b883d0f).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...ared/DesignSystem/Components/PrivacyNoteView.swift 0.00% 88 Missing ⚠️
...hared/API/Webhook/Sensors/WatchBatterySensor.swift 0.00% 2 Missing ⚠️
Sources/Shared/Environment/Environment.swift 50.00% 2 Missing ⚠️
...d/DesignSystem/Components/ExternalLinkButton.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3527      +/-   ##
==========================================
+ Coverage   45.33%   45.75%   +0.41%     
==========================================
  Files         225      228       +3     
  Lines       13390    13606     +216     
==========================================
+ Hits         6071     6225     +154     
- Misses       7319     7381      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@TimoPtr TimoPtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a big PR 👏🏻 I don't see any test is that on purpose? Do we have screenshot testings on this new screens?

@bgoncal
Copy link
Member Author

bgoncal commented Apr 8, 2025

Quite a big PR 👏🏻 I don't see any test is that on purpose? Do we have screenshot testings on this new screens?

Still coming in this PR

@bgoncal bgoncal force-pushed the onboarding-1 branch 3 times, most recently from edd8672 to 46b9a6f Compare April 8, 2025 18:35
@bgoncal bgoncal force-pushed the onboarding-1 branch 2 times, most recently from c799949 to c51822f Compare April 8, 2025 20:38
@bgoncal bgoncal merged commit 16f5a1b into master Apr 8, 2025
13 checks passed
@bgoncal bgoncal deleted the onboarding-1 branch April 8, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants