-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and migrate onboarding screens to SwiftUI #3527
Conversation
1 build increased size
Home Assistant 2025.4 (2025.4847)
|
Item | Install Size Change |
---|---|
Shared | ⬆️ 61.4 kB |
📝 logo-horizontal-text-dark.png | ⬆️ 17.3 kB |
🗑 HomeAssistant.OnboardingManualURLViewController | ⬇️ -17.2 kB |
🗑 HomeAssistant.OnboardingScanningViewController | ⬇️ -16.7 kB |
📝 logo-horizontal-text.png | ⬆️ 16.4 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3527 +/- ##
==========================================
+ Coverage 45.33% 45.75% +0.41%
==========================================
Files 225 228 +3
Lines 13390 13606 +216
==========================================
+ Hits 6071 6225 +154
- Misses 7319 7381 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a big PR 👏🏻 I don't see any test is that on purpose? Do we have screenshot testings on this new screens?
Sources/App/Onboarding/Screens/OnboardingPermissions/LocationPermissionView.swift
Outdated
Show resolved
Hide resolved
Sources/App/Onboarding/Screens/OnboardingPermissions/LocationPermissionView.swift
Show resolved
Hide resolved
Sources/App/Onboarding/Screens/OnboardingPermissions/LocationPermissionView.swift
Outdated
Show resolved
Hide resolved
Sources/App/Onboarding/Screens/OnboardingPermissions/LocationPermissionView.swift
Outdated
Show resolved
Hide resolved
Still coming in this PR |
edd8672
to
46b9a6f
Compare
c799949
to
c51822f
Compare
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
onboarding-low.mov