Fixes hang introduced by logging in sp_init(). #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging initialization relies on environment variables, and some of those variables originate in the flux shell. Initiali- zation prior to those values being transferred can result in a hang. This PR moves the transfer code into flux_plugin_init(), which is the first spindle-provided callback to be executed. Passes all runTests on Tuolumne.
|
Thanks for the reminder on this. This is already fixed in devel. I moved the SPINDLE_TEST environment handling to above the first debug_print in sp_init() in a recent-ish commit. I think that has the same effect as these changes. Moving to flux_plugin_init, as this PR does, is probably better. It'll harder to make a future mistake and put a debug_print to early in sp_init(). But this no longer fixes anything and probably doesn't have the priority it used to. You can either cleanup the conflict and re-submit this--I'll merge it. Or we can just close it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging initialization relies on environment variables, and some of those variables originate in the flux shell. Initiali- zation prior to those values being transferred can result in a hang.
This PR moves the transfer code into flux_plugin_init(), which is the first spindle-provided callback to be executed.
Passes all runTests on Tuolumne.
Fixes #79