Skip to content

fix: Improve attr-value-no-duplication logic #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 17, 2025

Ignore content (otherwise will have problems with meta descriptions using a word twice etc.

Ignore `content` (otherwise will have problems with meta descriptions using a word twice etc.
@coliff coliff requested a review from thedaviddias as a code owner June 17, 2025 07:58
@github-actions github-actions bot added documentation dependencies Pull requests that update a dependency file test labels Jun 17, 2025
gemini-code-assist[bot]

This comment was marked as resolved.

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (95e6a13) to head (5413b4f).
Report is 85 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #1664      +/-   ##
===========================================
+ Coverage   96.99%   100.00%   +3.00%     
===========================================
  Files           2         1       -1     
  Lines        1628         1    -1627     
  Branches      335         0     -335     
===========================================
- Hits         1579         1    -1578     
+ Misses         49         0      -49     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aadd4cf...5413b4f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coliff coliff merged commit 3f3a048 into main Jun 17, 2025
22 checks passed
@coliff coliff deleted the dev/coliff/improve-attr-duplicate-value-logic branch June 17, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant