Skip to content

Translate unit3 into Chinese #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

ShawnSiao
Copy link
Contributor

Translate unit3 into Chinese. #424

@ShawnSiao ShawnSiao changed the title Translate unit3 to Chinese Translate unit3 into Chinese Apr 13, 2025
@sergiopaniego
Copy link
Member

Hi! Thanks for the translation 😄 Ping me when ready for review.

@ShawnSiao
Copy link
Contributor Author

@sergiopaniego Yes, you can review it now, thanks.

Copy link
Member

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShawnSiao
Thanks for the PR 😄 We need to update the toctree accordingly:

RuntimeError: The following files are not present in the table of contents:
- unit3/agentic-rag/conclusion
- unit3/agentic-rag/invitees
- unit3/agentic-rag/agent
- unit3/agentic-rag/introduction
- unit3/agentic-rag/agentic-rag
- unit3/agentic-rag/tools
Add them to ../agents-course/units/zh-CN/_toctree.yml.

Could you update it?

@ShawnSiao
Copy link
Contributor Author

Hi @ShawnSiao Thanks for the PR 😄 We need to update the toctree accordingly:

RuntimeError: The following files are not present in the table of contents:
- unit3/agentic-rag/conclusion
- unit3/agentic-rag/invitees
- unit3/agentic-rag/agent
- unit3/agentic-rag/introduction
- unit3/agentic-rag/agentic-rag
- unit3/agentic-rag/tools
Add them to ../agents-course/units/zh-CN/_toctree.yml.

Could you update it?

Yes.

@ShawnSiao
Copy link
Contributor Author

@sergiopaniego I have updated the _toctree.yml file, please review it. If you have any other questions, please contact me. Thank you.

@sergiopaniego
Copy link
Member

The problem is still present. In this case, we've more sections in the toctree that actually present.

RuntimeError: The following files are present in the table of contents but do not exist:
- bonus-unit2/introduction
- bonus-unit2/what-is-agent-observability-and-evaluation
- bonus-unit2/monitoring-and-evaluating-agents-notebook
- bonus-unit2/quiz
Remove them from ../agents-course/units/zh-CN/_toctree.yml.

We only need to add the ones that we have translated to the toctree.

@@ -118,7 +132,17 @@
title: 让我们为函数调用微调模型
- local: bonus-unit1/conclusion
title: 结论
- title: 附加单元 2. 智能体可观测性与评估
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the toctree based on the added sections 😄
Thanks again!!

@ShawnSiao
Copy link
Contributor Author

The problem is still present. In this case, we've more sections in the toctree that actually present.

RuntimeError: The following files are present in the table of contents but do not exist:
- bonus-unit2/introduction
- bonus-unit2/what-is-agent-observability-and-evaluation
- bonus-unit2/monitoring-and-evaluating-agents-notebook
- bonus-unit2/quiz
Remove them from ../agents-course/units/zh-CN/_toctree.yml.

We only need to add the ones that we have translated to the toctree.

ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants