-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Translate unit3 into Chinese #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Translate unit3 to Chinese
Hi! Thanks for the translation 😄 Ping me when ready for review. |
@sergiopaniego Yes, you can review it now, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ShawnSiao
Thanks for the PR 😄 We need to update the toctree accordingly:
RuntimeError: The following files are not present in the table of contents:
- unit3/agentic-rag/conclusion
- unit3/agentic-rag/invitees
- unit3/agentic-rag/agent
- unit3/agentic-rag/introduction
- unit3/agentic-rag/agentic-rag
- unit3/agentic-rag/tools
Add them to ../agents-course/units/zh-CN/_toctree.yml.
Could you update it?
Yes. |
@sergiopaniego I have updated the _toctree.yml file, please review it. If you have any other questions, please contact me. Thank you. |
The problem is still present. In this case, we've more sections in the toctree that actually present.
We only need to add the ones that we have translated to the toctree. |
units/zh-CN/_toctree.yml
Outdated
@@ -118,7 +132,17 @@ | |||
title: 让我们为函数调用微调模型 | |||
- local: bonus-unit1/conclusion | |||
title: 结论 | |||
- title: 附加单元 2. 智能体可观测性与评估 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the toctree based on the added sections 😄
Thanks again!!
ok. |
remove bonus-unit2 in _toctree
Translate unit3 into Chinese. #424