-
Notifications
You must be signed in to change notification settings - Fork 701
[inference] Necessary breaking change: nest task-specific route inside of model route #3044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3044 +/- ##
===========================================
+ Coverage 43.75% 81.00% +37.24%
===========================================
Files 124 124
Lines 12261 12430 +169
===========================================
+ Hits 5365 10069 +4704
+ Misses 6896 2361 -4535 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Just to make sure I understand from the context of this internal thread: the goal here is to point |
not necessarily TEI, but yeah, the same container would be able to answer both calls/tasks, unlike now where we need two (redundant) running containers (unless we'd make complex URL/route rewriting) Can you confirm this @oOraph? |
I added unit tests and tested the PR 👍 all good, let's merge this (the inference tests are passing). from huggingface_hub import InferenceClient
client = InferenceClient(provider="hf-inference")
similarities = client.sentence_similarity(
model="intfloat/e5-base-v2",
sentence="Hello, how are you?",
other_sentences=["Hello, how are you?", "I am fine, thank you!"],
)
print(similarities) |
…e of model route (#1426) equivalent of huggingface/huggingface_hub#3044
The alternative is just to break this feature...