Skip to content

Update section3.ipynb #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update section3.ipynb #592

wants to merge 1 commit into from

Conversation

cmar28
Copy link

@cmar28 cmar28 commented May 7, 2025

What does this PR do?

  • evaluation_strategy is no longer a valid keyword for the latest trl/transformers API. The parameter was renamed a few releases ago (along with save_strategy, log_strategy, etc.). The parameter name has changed to eval_strategy
  • tokenizer was taken out of the SFTTrainer constructor in TRL ≥ 0.16. The callable you pass is now called processing_class

Fixes # (issue)

Who can review?

Feel free to tag members/contributors who may be interested in your PR.

- evaluation_strategy is no longer a valid keyword for the latest
trl/transformers API. The parameter was renamed a few releases ago (along with save_strategy, log_strategy, etc.). The parameter name has changed to eval_strategy
- tokenizer was taken out of the SFTTrainer constructor in TRL ≥ 0.16. The callable you pass is now called processing_class
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant