Skip to content

Remove duplicate short option '-p' to fix router executable #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

cebtenzzre
Copy link
Contributor

Fixes #601 which appears to be a regression caused by #589.

@cebtenzzre
Copy link
Contributor Author

cc @kozistr @Narsil

Copy link
Contributor

@kozistr kozistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing my mistake. looks good to me!

Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the prompt fix @cebtenzzre!

@alvarobartt alvarobartt merged commit 079eff0 into huggingface:main Apr 29, 2025
@cebtenzzre cebtenzzre deleted the fix-port-arg branch April 30, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Short option names must be unique for each argument, but '-p' is in use by both 'port' and 'prometheus_port'
3 participants