fix: RawImage.fromURL error when input file url

[himself65]

Upstream: run-llama/LlamaIndexTS#1855

fs.existSync(path) will assume path is a posix/win32 format if you give a string, so you will need pass url.pathname

[himself65]

/cc @xenova do you have a change to look at this? /

[xenova]

Hi @himself65 👋 Can you give an example of a URL which has this problem? The if clause should not allow invalid URLs to pass this step.

[himself65]

Hi @himself65 👋 Can you give an example of a URL which has this problem? The if clause should not allow invalid URLs to pass this step.

Yes, we were using file: protocol in node.js, and file protocol is a standard in node.js. And this is a regression because our test is working in <=4.0.0

const imageUrl = new URL(
  "../../fixtures/img/llamaindex-white.png",
  import.meta.url,
);

const nodes = [
  new ImageNode({
    image: imageUrl,
  }),
];

[himself65]

Docs: https://nodejs.org/api/fs.html#file-url-paths

[xenova]

That's a valid use-case, thanks for reporting! This will be merged in v3.5.1 💪

[xenova]

Should we perhaps check that the URL uses a valid file:// schema? Is there any other case where .pathname would be valid (on a non-file URL?)