-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the model card for CLIP #37040
Conversation
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@stevhliu Are there any changes required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic start! 🔥
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
All the suggested changes have been incorporated into the docs. Also, are model-specific loaders and processors being deprecated or are we just omitting them from the initial description about the model for standardization's sake? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! Just a few more changes and we can merge 🚀
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
@stevhliu Done! Let's merge this, I'll get started on another model. |
* Update clip.md * Update docs/source/en/model_doc/clip.md Co-authored-by: Steven Liu <[email protected]> * Update docs/source/en/model_doc/clip.md Co-authored-by: Steven Liu <[email protected]> * Update docs/source/en/model_doc/clip.md Co-authored-by: Steven Liu <[email protected]> * Incorporated suggested changes * Update docs/source/en/model_doc/clip.md Co-authored-by: Steven Liu <[email protected]> * Update docs/source/en/model_doc/clip.md Co-authored-by: Steven Liu <[email protected]> * Update docs/source/en/model_doc/clip.md Co-authored-by: Steven Liu <[email protected]> --------- Co-authored-by: Steven Liu <[email protected]>
What does this PR do?
As suggested in this issue - #36979 (comment) - this PR updates the documentation of the CLIP model, which will now be aligned with the standardized format for all the docs.
Who can review?
@stevhliu, please let me know if any changes are needed.