Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Model Card for ModernBERT #37052

Merged
merged 7 commits into from
Apr 3, 2025

Conversation

ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Mar 27, 2025

What does this PR do?

As described in the issue, this PR updates the model card for ModernBERT. Please let me know if any modifications are required and I will make the necessary changes.

Fixes #36979

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

@stevhliu

@github-actions github-actions bot marked this pull request as draft March 27, 2025 19:03
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@ParagEkbote ParagEkbote marked this pull request as ready for review March 27, 2025 19:04
@github-actions github-actions bot requested a review from stevhliu March 27, 2025 19:04
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see your contributions in Transformers as well! 🥳

@ParagEkbote ParagEkbote requested a review from stevhliu March 29, 2025 06:28
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few more nits!

@ParagEkbote
Copy link
Contributor Author

Could you please review?

cc: @stevhliu

@ParagEkbote ParagEkbote requested a review from stevhliu April 3, 2025 16:45
@stevhliu stevhliu merged commit 15ac2b6 into huggingface:main Apr 3, 2025
10 checks passed
@ParagEkbote ParagEkbote deleted the Model-Card-For-ModernBERT branch April 4, 2025 00:21
yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Apr 5, 2025
* Modify Model Card for ModernBERT.

* Update as per code review.

Co-authored-by: Steven Liu <[email protected]>

* Update model card.

* Update model card.

---------

Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Community contributions] Model cards
3 participants