Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated model card for qwen_2.5_vl #37099

Merged
merged 17 commits into from
Apr 3, 2025
Merged

feat: updated model card for qwen_2.5_vl #37099

merged 17 commits into from
Apr 3, 2025

Conversation

arkhamHack
Copy link
Contributor

@arkhamHack arkhamHack commented Mar 29, 2025 •
edited by stevhliu
Loading

What does this PR do?

#36979
This pr updates the model card for Qwen2.5-VL

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions bot marked this pull request as draft March 29, 2025 10:13
@github-actions GitHub Actions
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@arkhamHack arkhamHack marked this pull request as ready for review March 29, 2025 10:23
@github-actions github-actions bot requested a review from stevhliu March 29, 2025 10:23
@Rocketknight1
Copy link
Member

cc @stevhliu

@stevhliu stevhliu mentioned this pull request Mar 31, 2025
Open
stevhliu
stevhliu reviewed Mar 31, 2025
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice, just missing a few notes and quantization example!

@arkhamHack arkhamHack requested a review from stevhliu April 1, 2025 08:39
@arkhamHack
Copy link
Contributor Author

hi @stevhliu . I have made the changes you requested. Could you review this pr? Thanks.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu reviewed Apr 2, 2025
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few more changes to go!

docs/source/en/model_doc/qwen2_5_vl.md Outdated
max_pixels = 1024*28*28
processor = AutoProcessor.from_pretrained("Qwen/Qwen2.5-VL-7B-Instruct", min_pixels=min_pixels, max_pixels=max_pixels)
```
- We can implement flash attention 2 to speed up generation as shown below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this note

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive removed the flash attention 2 note from here . hope the code snippet before that is ok to stay.

@arkhamHack arkhamHack requested a review from stevhliu April 3, 2025 00:22
@arkhamHack
Copy link
Contributor Author

arkhamHack commented Apr 3, 2025 •
edited
Loading

Hi @stevhliu made the remaining changes. Just hope that the above comment i've left is fine though.

stevhliu
stevhliu approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@stevhliu stevhliu merged commit 1b29409 into huggingface:main Apr 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkhamHack @Rocketknight1 @HuggingFaceDocBuilderDev @stevhliu