Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated model card for Mistral #37156

Merged
merged 14 commits into from
Apr 7, 2025
Merged

Conversation

NahieliV
Copy link
Contributor

This PR updates the model card for Mistral and follows the template outlined in the issue. Please let me know if any changes need to be made.

Fixes #36979

Before submitting

  • This PR improves the docs.

Who can review?

@stevhliu

@github-actions github-actions bot marked this pull request as draft March 31, 2025 20:12
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@NahieliV NahieliV marked this pull request as ready for review March 31, 2025 20:24
@github-actions github-actions bot requested a review from stevhliu March 31, 2025 20:25
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and clean! 👏

<img src="https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/transformers/model_doc/mistral-attn-mask.png"/>
</div>

## Notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've covered pretty much everything so no need for a ##Notes section and can remove the other text under it.

@NahieliV NahieliV force-pushed the mistral_model_card branch from b11f6cb to ee28f32 Compare April 2, 2025 19:41
@NahieliV
Copy link
Contributor Author

NahieliV commented Apr 2, 2025

@stevhliu , I have incorporated your suggestions. Should be good now!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just several more formatting changes!

@NahieliV NahieliV force-pushed the mistral_model_card branch from 061eceb to 2ff53ec Compare April 3, 2025 20:11
@NahieliV
Copy link
Contributor Author

NahieliV commented Apr 4, 2025

@stevhliu , the modifications are done :)

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🚀

@stevhliu stevhliu merged commit f8a1680 into huggingface:main Apr 7, 2025
10 checks passed
vasqu pushed a commit to vasqu/transformers that referenced this pull request Apr 7, 2025
* model card for Mistral

* Update docs/source/en/model_doc/mistral.md

Co-authored-by: Steven Liu <[email protected]>

* Apply suggestions from code review

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/mistral.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/mistral.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/mistral.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/mistral.md

Co-authored-by: Steven Liu <[email protected]>

* apply suggestions

* fix typo

* updated with comments

* updated with comments

* updated with comments

* remove hfoption block

---------

Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Community contributions] Model cards
3 participants