-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated model card for Mistral #37156
Conversation
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice and clean! 👏
docs/source/en/model_doc/mistral.md
Outdated
<img src="https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/transformers/model_doc/mistral-attn-mask.png"/> | ||
</div> | ||
|
||
## Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've covered pretty much everything so no need for a ##Notes
section and can remove the other text under it.
b11f6cb
to
ee28f32
Compare
@stevhliu , I have incorporated your suggestions. Should be good now! |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just several more formatting changes!
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
061eceb
to
2ff53ec
Compare
@stevhliu , the modifications are done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 🚀
* model card for Mistral * Update docs/source/en/model_doc/mistral.md Co-authored-by: Steven Liu <[email protected]> * Apply suggestions from code review Co-authored-by: Steven Liu <[email protected]> * Update docs/source/en/model_doc/mistral.md Co-authored-by: Steven Liu <[email protected]> * Update docs/source/en/model_doc/mistral.md Co-authored-by: Steven Liu <[email protected]> * Update docs/source/en/model_doc/mistral.md Co-authored-by: Steven Liu <[email protected]> * Update docs/source/en/model_doc/mistral.md Co-authored-by: Steven Liu <[email protected]> * apply suggestions * fix typo * updated with comments * updated with comments * updated with comments * remove hfoption block --------- Co-authored-by: Steven Liu <[email protected]>
This PR updates the model card for Mistral and follows the template outlined in the issue. Please let me know if any changes need to be made.
Fixes #36979
Before submitting
Who can review?
@stevhliu