Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated T5 model card with standardized format #37261

Merged
merged 16 commits into from
Apr 4, 2025

Conversation

ShararehY
Copy link
Contributor

What does this PR do?

Updated T5 model card with standardized format

Fixes #36979

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu

@github-actions github-actions bot marked this pull request as draft April 3, 2025 18:46
Copy link

github-actions bot commented Apr 3, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@ShararehY ShararehY marked this pull request as ready for review April 3, 2025 18:52
@github-actions github-actions bot requested a review from stevhliu April 3, 2025 18:52
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, very clean! 👏

@ShararehY
Copy link
Contributor Author

Hi @stevhliu , Thanks for the suggestions! I applied the changes, could you please review it again?

@ShararehY ShararehY requested a review from stevhliu April 4, 2025 18:38
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one tiny nit then we can merge :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 46d7391 into huggingface:main Apr 4, 2025
10 checks passed
yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Apr 5, 2025
* Updated T5 model card with standardized format

* Updated T5 model card with standardized format, fixed typo

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

* Apply reviewer suggestions

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <[email protected]>

---------

Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Community contributions] Model cards
3 participants