Skip to content

[Qwen2.5-Omni] Fix dtype of cos,sin when used with flash attention #38453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

HarryHsing
Copy link
Contributor

What does this PR do?

Fixes a dtype mismatch in Qwen2.5-Omni models when Flash Attention is enabled:
sin and cos positional embeddings are now explicitly cast to the same dtype as the working tensor.

Related issue: #38451

Thanks @zucchini-nlp for validating the fix!

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HarryHsing HarryHsing changed the title Fix dtype of cos,sin when used with flash attention [Qwen2.5-Omni] Fix dtype of cos,sin when used with flash attention May 28, 2025
Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you update the modulear_qwen_omni.py file and then run make fix-copies?

@HarryHsing
Copy link
Contributor Author

HarryHsing commented May 29, 2025

update the modulear_qwen_omni.py

I've updated modular_qwen_omni.py and successfully ran make fix-copies.

Here is the output from the command:

python utils/check_copies.py --fix_and_overwrite
python utils/check_modular_conversion.py --fix_and_overwrite
No models files or model tests in the diff, skipping modular checks
python utils/check_dummies.py --fix_and_overwrite
python utils/check_doctest_list.py --fix_and_overwrite
python utils/check_docstrings.py --fix_and_overwrite

No files were updated during make fix-copies.

Let me know if there's anything else needed. Thanks!

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@zucchini-nlp zucchini-nlp enabled auto-merge (squash) May 29, 2025 18:12
@zucchini-nlp zucchini-nlp merged commit 42ef218 into huggingface:main May 29, 2025
14 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants