INTERVAL support, date pseudo literals TIMESTAMP and TIME literals. #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchasapis
force-pushed
the
interval_date_psedo_literals
branch
from
08fe178 to
d2da311
Compare
dey4ss
reviewed
Jun 12, 2025
src/sql/CreateStatement.h
Outdated
| @@ -61,6 +61,7 @@ struct ColumnDefinition : TableElement { | |||
| ColumnType type; | |||
| bool nullable; | |||
| std::vector<ReferencesSpecification*>* references; | |||
| Expr* defaultValue{nullptr}; | |||
There was a problem hiding this comment.
This member is unused, isn't it?
kchasapis
force-pushed
the
interval_date_psedo_literals
branch
from
d2da311 to
9109fe0
Compare
The interval was not allowed to be a column data type. With this patch we add this support. We add support for the pseudo literals CURRENT_TIME, CURRENT_TIMESTAMP, CURRENT_DATE. Also, we add support for TIMESTAMP and TIME literals. The user can now explicitly set the type of the string value it follows with TIMESTAMP 'value' and TIME 'value. DATE was already supported.
kchasapis
force-pushed
the
interval_date_psedo_literals
branch
from
9109fe0 to
ef49bda
Compare
Thanks for your message. I have added unit tests. Please, let me know if there is anything else needed from my side to get started in the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interval was not allowed to be a column data type. With this patch we add this support.
We add support for the pseudo literals
CURRENT_TIME, CURRENT_TIMESTAMP, CURRENT_DATE.
Also, we add support for TIMESTAMP and TIME literals. The user can now explicitly set the type of the string value it follows with TIMESTAMP 'value' and TIME 'value.
DATE was already supported.