-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to add rand={randomNumber}
to the urls to inspect
#2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 👍 but deploy_block ☁️ with some questions
If the provided urls.json file is bad, it exits early on JSON.parse() and doesn't get to this check, thus, dropping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 👍
Used structuredClone() to clone the inital inspectList. The `structuredClone()` is avaliable on node +17 versions, thus, updated the node version constraint in package.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 👍 and un_deploy_block ⚡
deploy_block ☁️ on #1 going out first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 👍
un_deploy_block ⚡ #1 has been merged. |
Summary
This adds
rand={randomNumber}
query param to the urls.This is to ensure that we never hit CDN cache.
QA notes
pnpm install
urls.json
file:pnpm run build
pnpm start
rand
param is added to the urls when loggingupdatedInspectList
.closes https://github.com/iFixit/server-templates/issues/4140