Skip to content

for burst mode dmar, define as DMA_REQUEST_TIMx_UP #10900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sensei-hacker
Copy link
Collaborator

This small change seems to solve the issue on DMA / DSHOT not working on one pin on the H743:

#10835

As tested with this target:
#10843

However, I would like to request review by someone who understands the DMA better, probably @shirase or @bkleiner ?

@sensei-hacker sensei-hacker requested a review from bkleiner June 2, 2025 00:40
@sensei-hacker sensei-hacker marked this pull request as ready for review June 2, 2025 04:00
@shirase
Copy link
Contributor

shirase commented Jun 2, 2025

Add USE_DSHOT_DMAR in target. Nothing else. DEF_TIM_DMA__BTCH_TIM4_CH4 - this channel does not exist physically.

@bkleiner
Copy link
Collaborator

bkleiner commented Jun 2, 2025

Add USE_DSHOT_DMAR in target. Nothing else. DEF_TIM_DMA__BTCH_TIM4_CH4 - this channel does not exist physically.

Agreed, using the UP request to substitute is not a good workaround here.

@sensei-hacker
Copy link
Collaborator Author

sensei-hacker commented Jun 2, 2025

Thanks for the responses!

Add USE_DSHOT_DMAR in target. Nothing else.

That's the first thing I tried. Unfortunately that didn't work

When that did not work, I went on the adventure trying to figure out how this stuff works. I found that this change made it "work", but I don't have the background knowledge to know the best/right way to fix it.

@shirase
Copy link
Contributor

shirase commented Jun 3, 2025

dma burst mode use first initialized dma channel for all timer channels. It can not work if first initialized channel is empty. Using DMA_REQUEST_TIM4_UP for dma burst is not break anything. This PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants