fix: phantom scroll when params.footer.enable is set to false
#658
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Zabriskije
changed the title
params.footer.enable is set to falseparams.footer.enable is set to false
|
let me look into this, this might actually be a small bug |
|
turns out the sidebar bottom menu container was calculated to 61 pixels in the browser, while 3.75rem is 60 pixels. so the total height of sidebar exceeds the view height by 1 pixel i updated your PR to put a limit to the sidebar bottom container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
params.footer.enableis set tofalse, it causes a phantom scroll effect (more visible on pages with little content). Here's a preview:The problem is
--menu-height: 3.75rem, but just setting it to--menu-height: 3.8remfixes the issue.