(c2rust-analyze) Cleanup/simplify visit_cast (extracted from #883)
#900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utside of the `match`.
… `if` rather than an `if let`.
…()` to avoid any unintended clones.
…tee_ty` instead of custom `match`.
… an `if let` into just an `assert_matches!`.
…om and to in a cast.
aneksteind
reviewed
Apr 26, 2023
aneksteind
approved these changes
Apr 26, 2023
…dy contained within `to_lty`.
kkysen
force-pushed
the
kkysen/analyze-visit-cast
branch
from
3906c89 to
df6a469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up and simplifies some of the code from #883 in preparation for the string cast PRs, #739 and #741.
It extracts things into a separate
visit_castmethod, simplifies a few things, and clarifies exactly whichTys andLTys are from and to in a cast. This makes it easier to understand and read, and makes it simpler to rebase #739 onto it.