Fix electron target #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsobear
commented
Mar 1, 2020
| @@ -10,7 +10,8 @@ function createWindow(): BrowserWindow { | |||
| width: 800, | |||
| height: 600, | |||
| webPreferences: { | |||
| preload: path.join(__dirname, 'preload.js') | |||
| preload: path.join(__dirname, 'preload.js'), | |||
| nodeIntegration: true | |||
imsobear
commented
Mar 1, 2020
| "rootDir": "./", | ||
| "outDir": "../main_dist" | ||
| } | ||
| } |
|
有个问题可能要处理下：main 的代码变更后必须重新 app:start 才能生效？ |
|
还有一个：
我看下怎么在项目内能统一定义 registry，另外已有的怎么才能改掉？ |
这个问题我先用编辑器统一改掉了，这个问题主要还是 yarn 不应该在 lock 文件里冗余 registry，我看这个 feature 可能要到 2.0 才能加：yarnpkg/yarn#5892 暂时的话：如果全局没配置自定义的 registry 那就没问题，如果配置了话，每次添加依赖时加一下命令行参数： |
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 5 5
=====================================
Hits 5 5Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.