Build serde without default features #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually need any std/alloc features of `serde`, but our dev-dependency on `serde_test` was indirectly turning on its default features. However, if we isolate that testing to a separate crate in the workspace, Cargo will compute the enabled features separately. Now we can actually enable the `serde-1` feature in `test-nostd` too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually need any std/alloc features of
serde, but ourdev-dependency on
serde_testwas indirectly turning on its defaultfeatures. However, if we isolate that testing to a separate crate in the
workspace, Cargo will compute the enabled features separately. Now we
can actually enable the
serde-1feature intest-nostdtoo!Closes #109.