Allow AlwaysProp #76
Open
Allow AlwaysProp #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @salernosimone this looks good! Would you be able to add a test for the new behavior? |
|
I'll try |
|
I’m happy to help if you’d like! |
akx
reviewed
Apr 20, 2025
inertia/http.py
Outdated
| @@ -92,14 +92,20 @@ def build_props(self): | |||
| **(self.request.inertia), | |||
| **self.props, | |||
| } | |||
| delete_queue = [] | |||
There was a problem hiding this comment.
This should probably be a set() instead of an ordered list.
akx
reviewed
Apr 23, 2025
|
I added 2 test cases. |
Co-authored-by: Aarni Koskela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Laravel adapter has a
Inertia::alwaysmethod to always include data (on standard visits and on partial reloads without being explicitly requested). This pull request implements it.