Skip to content

[2.x] Revert IDE helpers #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

ycs77
Copy link
Contributor

@ycs77 ycs77 commented Oct 13, 2024

Relation PR: #654, #674 (These PRs have no conflicts and can all be merged)

Because IDE helpers caused trouble, so revert #413 and #625.


The above Illuminate\Testing part of the IDE helpers was created by @claudiodekker, I'm not the author, so I didn't remove it.

@ycs77 ycs77 mentioned this pull request Oct 13, 2024
@SamMakesCode
Copy link

Hope this gets merged - it's small, but a great QOL change

@siarheipashkevich
Copy link

@ycs77 please merge it

@ycs77
Copy link
Contributor Author

ycs77 commented Mar 12, 2025

I can't merge it because I'm not the maintainer, I do not have permission.😭

@ycs77
Copy link
Contributor Author

ycs77 commented Mar 12, 2025

@taylorotwell @joetannenbaum could you merge this PR and #654, #674?

@joetannenbaum
Copy link
Contributor

Sorry, what trouble are they causing?

@ycs77
Copy link
Contributor Author

ycs77 commented Apr 10, 2025

Sorry, what trouble are they causing?

Since I released the IDE helper update (#413, #625) before, many users have reported that the IDE IntelliSense is broken (#625 (comment), #654), although they don't use IDE helper, so this PR will revert the PRs that caused the problem.

Regarding the PR #674 and #654 on the 1.x branch, I think merging it will fix this issue for the users to using 1.x, it just removes the IDE helper file, will not modify any current features, @joetannenbaum can you consider merging it?

@ycs77
Copy link
Contributor Author

ycs77 commented Apr 11, 2025

Then I add some changes about these PRs:

If ignore export _ide_helpers.php in .gitattributes, then will not download the _ide_helpers.php in running composer require.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants