-
Notifications
You must be signed in to change notification settings - Fork 301
Iceberg Integration documentation #5918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good. My suggestions are mostly for following our style and "tightening up". We should add examples where noted ASAP, but it shouldn't necessarily hold up publishing when the feature is ready.
Thank you for the suggestions and help! I should probably go slower and triple check that I am using the Google developers documentation style guide. @jstirnaman |
Ideally, Vale should be catching violations as well, but I think we're missing some config for the newer directories.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor suggestions
#### Example: Enable Iceberg feature and export a snapshot | ||
|
||
```sh | ||
# Enable Iceberg feature | ||
$ influxctl enable-iceberg | ||
|
||
# Export a snapshot | ||
$ influxctl export --namespace foo --table bar | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commands should be used in the process above, not influxdb_iox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, we should save the material for when more self-support features are added. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the notes here, I'm pushing an update to your branch--I'll PR so you can see the diff.
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
…h support assistance
- Add directory and frontmatter - Revise content to be Cloud Dedicated specific, omitting implementation and config detail that will be handled by InfluxData Support - Fix code samples - Organize, clean up headings - TODO: Comment out influxctl and API code if necessary (until features are completed) - TODO: Verify details with PM - TODO: Move content as noted in the iceberg-for-snowflake.md comment
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
Co-authored-by: Scott Anderson <[email protected]>
- Merge fixes - Provide instruction for checking snapshot status - Cleanup
Description
To introduce documentation for the new Iceberg integration with Snowflake for InfluxDB Cloud Dedicated. To create documentation that allows users to export time series data snapshots into Apache Iceberg format and query them directly from Snowflake—without the need for complex ETL processes.
To-do
Why This Matters
This documentation gives users the information they need to request access and understand the setup and usage of the integration clearly and confidently.