Skip to content

fix(rust/signed-doc): Preserve original raw_bytes #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 26, 2025

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented May 22, 2025

Description

Fixed a newparameters field backwards compatibility.
If category_id, campaign_id or brand_id was passed (as an alias of parameters) encoding implementation was not symetric with decoding impl (we were lossing original representation).

Related Issue(s)

Closes #344

@Mr-Leshiy Mr-Leshiy self-assigned this May 22, 2025
@Mr-Leshiy Mr-Leshiy added bug Something isn't working review me PR is ready for review do not merge yet PR is not ready to merge yet labels May 22, 2025
@Mr-Leshiy Mr-Leshiy requested a review from stevenj May 22, 2025 21:58
Copy link
Contributor

github-actions bot commented May 22, 2025

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@bkioshn
Copy link
Contributor

bkioshn commented May 23, 2025

Test locally, this fix work

@Mr-Leshiy Mr-Leshiy merged commit 9ef6f5d into main May 26, 2025
24 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/signed-doc-preserve-bytes branch May 26, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalyst Signed Document preserve original bytes from the decoding process
2 participants