Skip to content

Add a skill to find available time slots for a meeting #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

huangyum
Copy link

@huangyum huangyum commented Mar 12, 2024

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.

Describe the contribution to the taxonomy

  • New skill to find available time slots for a meeting based on participants' schedule.

Input given at the prompt

  Mary is busy from 10:00 to 13:00, Max is busy from 16:00 to 17:00, and Lily is free from 9:00 to 14:00. Would you please list the available time slots for a one-hour meeting between 9:00 to 18:00 for them together?

Response that was received

│ Between 9:00 to 18:00, Lily is free from 9:00 to 14:00. Mary is busy from 10:00 to 13:00, so she cannot participate in a one-hour │
│ meeting during that time. Max is busy from 16:00 to 17:00. Considering their availability, the possible time slots for a one-hour │
│ meeting are:                                                                                                                      │
│                                                                                                                                   │
│ 1. 9:00 - 10:00                                                                                                                   │
│ 2. 11:00 - 12:00                                                                                                                  │
│ 3. 12:00 - 13:00 (Lily cannot join this slot)                                                                                     │
│ 4. 14:00 - 15:00                                                                                                                  │
│ 5. 15:00 - 16:00 (Max cannot join this slot)                                                                                      │
│ 6. 17:00 - 18:00 (Max cannot join this slot) 

Response that is now received instead

  No hardware resource for the training.

Contribution checklist

  • Contribution was tested with lab generate
  • No errors or warnings were produced by lab generate
  • All commits are signed off (DCO)
  • The qna.yaml file was [linted]

@huangyum huangyum requested a review from a team as a code owner March 12, 2024 05:23
@huangyum huangyum force-pushed the meeting_sche branch 4 times, most recently from e67bc1b to 62f7d54 Compare March 12, 2024 09:01
@huangyum
Copy link
Author

huangyum commented Mar 12, 2024

Lab generate result:

100%|██████████████████████████████████████████████████████████████████████████████████████████████| 100/100 [57:04<00:00, 38.31s/it]
INFO 2024-03-12 05:45:35,397 generate_data.py:436 Generation took 3424.58s
100%|██████████████████████████████████████████████████████████████████████████████████████████████| 100/100 [57:04<00:00, 34.25s/it]

@mairin mairin added the skill (Auto labeled) label Mar 16, 2024
@obuzek
Copy link
Contributor

obuzek commented Mar 26, 2024

Can you mix in some 12-hour time formats into this so the model can learn to use both?

I think it's quite likely that the generated examples would rely too much on the model's inability to do computation tasks, but this one might be common enough to try.

@obuzek obuzek added triage-requested-changes skill has been reviewed; changes requested from contributor skill category: word problems labels Mar 26, 2024
@huangyum huangyum requested a review from a team as a code owner March 29, 2024 07:15
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label Mar 29, 2024
@huangyum
Copy link
Author

Hi, I added more questions/answers with 12 hour time format. Please let me know if anything more is needed. Thanks.

@jjasghar jjasghar closed this Apr 19, 2024
@n1hility
Copy link
Member

Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested:

https://forms.gle/V7SrPPMZDo6iGDYu8

@huangyum
Copy link
Author

@obuzek @n1hility Hi, I have recreated #1455 for this, would you pls help review it? Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skill (Auto labeled) triage-needed (Auto labeled) skill is ready to be triaged triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants