Skip to content

Improve test coverage in new AST code #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 15, 2025
Merged

Improve test coverage in new AST code #387

merged 5 commits into from
May 15, 2025

Conversation

Cirras
Copy link
Collaborator

@Cirras Cirras commented May 14, 2025

This PR improves test coverage in AttributeNodeImpl and InterfaceTypeNodeImpl.

Cirras added 4 commits May 14, 2025 18:07
@Cirras
Add colon delimiter to AttributeNode image
822ab4d
@Cirras
Always use the full attribute expression in the AttributeNode image
e84e7e1 
This is more consistent considering attributes can contain arbitrary
expressions. There was never any real reason to exclude the argument
list from these node images.
@Cirras
Use NameOccurrence::isAttributeReference instead of instanceof check
5912e45
@Cirras
Simplify InterfaceTypeNodeImpl::findFirstAttributeList implementation
6bbd27d 
This collapsed implementation eliminates unreachable lines.
Sadly, there's still an unreachable branch.
@Cirras Cirras requested a review from fourls May 14, 2025 09:27
fourls
fourls requested changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@fourls fourls left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good! Definitely a good idea to start testing some of these nodes a little more - there might be some low hanging fruit in terms of coverage that we can pick off over time.

I have a couple of minor notes.

@Cirras Cirras requested a review from fourls May 15, 2025 03:58
fourls
fourls approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@fourls fourls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fourls fourls merged commit d4318c6 into master May 15, 2025
4 checks passed
@Cirras Cirras deleted the coverage branch May 15, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fourls fourls fourls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cirras @fourls