[SYCL] Check that some device global uninitialized before locking #18041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Count number of not done initialization of device globals and take a lock only if something is not initialized yet.
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…nce before lockig.
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@maarquitos14 Could you please review this PR? We expect some performance improvement from these changes. |
| std::lock_guard<std::mutex> Lock(MDeviceGlobalInitializersMutex); | ||
| for (const device &Dev : Devs) { | ||
| auto Key = std::make_pair(Program, getSyclObjImpl(Dev)->getHandleRef()); | ||
| MDeviceGlobalInitializers.emplace(Key, BinImage); | ||
| auto [Iter, Inserted] = MDeviceGlobalInitializers.emplace(Key, BinImage); |
There was a problem hiding this comment.
I have a couple of questions:
- I see
MDeviceGlobalInitializersis anstd::map. Do we really need the elements to be sorted? If not, we can change tostd::unordered_map, which should provide better performance. - Are we expecting the inserted elements to be consecutive? Could we use
emplace_hintinstead?
There was a problem hiding this comment.
- I see
MDeviceGlobalInitializersis anstd::map. Do we really need the elements to be sorted? If not, we can change tostd::unordered_map, which should provide better performance.
Sure, done.
- Are we expecting the inserted elements to be consecutive? Could we use
emplace_hintinstead?
The key is a pair of pointers. I'm not sure what can be say about order of them.
There was a problem hiding this comment.
The key is a pair of pointers. I'm not sure what can be say about order of them.
Yep, that is my concern too. Maybe it's worth it to try and measure to see if it helps? I'll approve anyway in case you want to do that in a separate PR.
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@maarquitos14 Should we merge it? |
I don't have merge permissions, pinging @intel/llvm-gatekeepers should help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count number of not done initialization of device globals and take a lock only if something is not initialized yet.