Skip to content

[SYCL][UR][L0 v2] fix urMemBufferCreateWithNativeHandle for host memory #18066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

igchor
Copy link
Member

@igchor igchor commented Apr 16, 2025

In case of creating a buffer from native host memory pointer, there was a missing initialization step. Host memory content was not being copied to the underlying buffer device memory.

@igchor igchor requested a review from a team as a code owner April 16, 2025 18:43
@igchor igchor temporarily deployed to WindowsCILock April 16, 2025 18:43 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 16, 2025 18:55 — with GitHub Actions Inactive
@igchor igchor force-pushed the fix_native_buffer_host_mem branch from e8055c7 to 154e488 Compare April 16, 2025 19:05
@igchor igchor requested a review from a team as a code owner April 16, 2025 19:05
@igchor igchor temporarily deployed to WindowsCILock April 16, 2025 19:05 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 16, 2025 19:24 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 16, 2025 19:24 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 16, 2025 19:48 — with GitHub Actions Inactive
In case of creating a buffer from native host memory pointer,
there was a missing initialization step. Host memory content
was not being copied to the underlying buffer device memory.

Modify interop-level-zero-buffer.cpp test to verify
that the buffer is properly initialized.
@igchor
Copy link
Member Author

igchor commented Apr 18, 2025

@intel/llvm-gatekeepers this is ready to be merged

@sarnex sarnex merged commit b3a4387 into intel:sycl Apr 18, 2025
49 of 59 checks passed
@igchor igchor deleted the fix_native_buffer_host_mem branch April 18, 2025 17:21
vinser52 pushed a commit to sergey-semenov/llvm that referenced this pull request Apr 22, 2025
…ry (intel#18066)

In case of creating a buffer from native host memory pointer, there was
a missing initialization step. Host memory content was not being copied
to the underlying buffer device memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants